RDKB-66345 Disable 160MHz if DFS at boot up is false - #149
Open
pavankumar464 wants to merge 2 commits into
Open
Conversation
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the XB6 wireless configuration UI logic to ensure the 160MHz channel bandwidth option remains disabled when DFS-at-boot is false, even after users change channels in the UI.
Changes:
- Move
$dfsBootinitialization earlier so it’s available to channel change handlers. - When the user changes the channel away from 165, re-enable bandwidth options while preserving the DFS-at-boot restriction for 160MHz.
- Minor indentation/flow cleanup in existing DFS-at-boot gating logic.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| source/Styles/xb6/jst/wireless_network_configuration.jst | Preserve DFS-at-boot 160MHz disable behavior when channel selection changes. |
| source/Styles/xb6/jst/wireless_network_configuration_onewifi.jst | Same DFS-at-boot 160MHz restriction preservation for OneWiFi variant. |
| source/Styles/xb6/jst/wireless_network_configuration_edit.jst | Apply the same runtime channel-change restriction logic in the edit page. |
| source/Styles/xb6/jst/wireless_network_configuration_edit_onewifi.jst | Apply the same runtime channel-change restriction logic in the OneWiFi edit page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (4)
source/Styles/xb6/jst/wireless_network_configuration.jst:1021
- Optional: declare $dfsBoot with
varto avoid creating an implicit global (which can clash with other scripts on the page).
$dfsBoot= '<?% echo($dfsAtBootup); ?>';
source/Styles/xb6/jst/wireless_network_configuration_onewifi.jst:1040
- Optional: declare $dfsBoot with
varto avoid creating an implicit global (which can clash with other scripts on the page).
$dfsBoot= '<?% echo($dfsAtBootup); ?>';
source/Styles/xb6/jst/wireless_network_configuration_edit.jst:613
- Optional: declare $dfsBoot with
varto avoid creating an implicit global (which can clash with other scripts on the page).
$dfsBoot= '<?% echo($dfsAtBootup); ?>';
source/Styles/xb6/jst/wireless_network_configuration_edit_onewifi.jst:638
- Optional: declare $dfsBoot with
varto avoid creating an implicit global (which can clash with other scripts on the page).
$dfsBoot= '<?% echo($dfsAtBootup); ?>';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is triggered by User Story RDKB-12829